Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Improve List chapter screenshots and cross-links #5543

Merged
merged 1 commit into from
Nov 17, 2020
Merged

[Doc] Improve List chapter screenshots and cross-links #5543

merged 1 commit into from
Nov 17, 2020

Conversation

fzaninotto
Copy link
Member

  • Change initial image to something more representative
  • Rework <List> props sections name
  • Add more details about useListContext hook
  • Add mention of the ra-calendar elements

Before

marmelab com_react-admin_List html

After

127 0 0 1_4001_List html

@fzaninotto fzaninotto added the RFR Ready For Review label Nov 17, 2020
djhi
djhi approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djhi djhi merged commit a4f4737 into master Nov 17, 2020
@djhi djhi deleted the list-doc-improvements branch November 17, 2020 13:45
@djhi djhi added this to the 3.10.2 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @djhi