Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add component prop to SimpleForm #5703

Merged
merged 2 commits into from
Dec 23, 2020
Merged

Add component prop to SimpleForm #5703

merged 2 commits into from
Dec 23, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Dec 21, 2020 •
edited
Loading

Related to #5696.

So CardContentInner component could be overriden inside SimpleForm component.

I have to use container instead of component since react-final-form's FormRenderProps already has a component prop

@WiXSL WiXSL mentioned this pull request Dec 21, 2020
Closed
@fzaninotto
Copy link
Member

There is no component in FormRenderProps, it's in FormProps. How does it prevent you from using it in SimpleForm?

https://final-form.org/docs/react-final-form/types/FormRenderProps

@WiXSL
Copy link
Contributor Author

WiXSL commented Dec 22, 2020

You are right!
I must have been confused with a typescript error I was getting manipulating the code

@WiXSL WiXSL changed the title Add container prop to SimpleForm Add component prop to SimpleForm Dec 22, 2020
@fzaninotto fzaninotto merged commit 6cbfa2b into marmelab:next Dec 23, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.12 milestone Dec 23, 2020
@WiXSL WiXSL deleted the add-simplefor-container branch December 23, 2020 12:40
@fzaninotto fzaninotto mentioned this pull request Jan 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.12
Development

Successfully merging this pull request may close these issues.
2 participants
@WiXSL @fzaninotto