Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added possibility to pass isRequired as option to useInput hook #5812

Merged
merged 2 commits into from
Feb 11, 2021
Merged

added possibility to pass isRequired as option to useInput hook #5812

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8c417f
added possibility to pass isRequired as option to useInput hook
FACOLOMBANI Jan 22, 2021
63789e5
moved isRequired to InputProps as optional boolean
FACOLOMBANI Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ra-core/src/form/useInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ const useInput = ({
id: id || source,
input: options.input,
meta: options.meta,
isRequired: isRequired(validate),
isRequired: options.isRequired || isRequired(validate),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind moving the isRequired out of the options and directly in the InputProps as an optional boolean?

Copy link
Contributor Author

@FACOLOMBANI FACOLOMBANI Feb 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the change, is it ok like that?

};
}

Expand Down