Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass fullWidth to Labeled #6089

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Pass fullWidth to Labeled #6089

merged 1 commit into from
Mar 29, 2021

Conversation

seniorquico
Copy link
Contributor

I think this is how it should be, otherwise the fullWidth prop isn't really being passed through to the underlying Material UI components. However, we're looking at it to specifically help fix the visual layout on some more advanced show pages where we do something like the following:

<Show {...props}>
  <SimpleShowLayout>
    <ArrayField source="transactions" fullWidth label="Transactions">
      <Datagrid>
        <TextField source="id" label="Transaction ID" />

fullWidth ensures the container takes up 100%, which the data grid happily uses. Without passing it through, the data grid only takes up about 1/3 of the horizontal screen real estate.

@djhi
Copy link
Collaborator

djhi commented Mar 29, 2021

Thanks!

@djhi djhi added this to the 3.14 milestone Mar 29, 2021
@djhi djhi merged commit 8676001 into marmelab:next Mar 29, 2021
@seniorquico seniorquico deleted the fullwidth branch March 30, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants