Add Initial Support For Creation in Choices Inputs #6163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
force-pushed
the
quick-create-support
branch
from
135280c
to
6766b71
Compare
HALLERPierre
approved these changes
Apr 19, 2021
fzaninotto
requested changes
Apr 26, 2021
| expect(queryByRole('progressbar')).toBeNull(); | ||
| }); | ||
|
|
||
| test('should support creation of a new choice through the onCreate event', async () => { |
| /> | ||
| ); | ||
|
|
||
| expect(queryByRole('progressbar')).toBeNull(); | ||
| }); | ||
| }); | ||
|
|
||
| test('should support creation of a new choice through the onCreate event', async () => { |
| ).not.toBeNull(); | ||
| }); | ||
|
|
||
| test('should support creation of a new choice through the onCreate event with a promise', async () => { |
| onCreate: (choice: any) => void; | ||
| onCancel: () => void; | ||
| } | ||
| export const useCreateSuggestion = () => useContext(CreateSuggestionContext); |
There was a problem hiding this comment.
bad name, as it does not actually create anything
There was a problem hiding this comment.
You have a better one?
There was a problem hiding this comment.
useCreateSuggestionContext ?
djhi
force-pushed
the
quick-create-support
branch
from
4a84094
to
1f45d01
Compare
djhi
force-pushed
the
quick-create-support
branch
from
1f45d01
to
9f89713
Compare
|
Messed up my commits/rebase big time 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectInputAutocompleteInputReferenceInputAutocompleteArrayInputReferenceArrayInputSelectArrayInput