Export PublicFieldProps and InjectedFieldProps types (so devs can use them to define their own field components)
#6219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use them to define their own field components)
fzaninotto
approved these changes
Apr 29, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our admin app, we create a lot of our own custom
*Fieldcomponents. When defining them, we need to add typescript definitions for props likeaddLabel?: boolean, which aren't used directly by the field component, but by the components wrapping it (e.g.Labeled).All props like that are currently nicely defined in
react-adminasPublicFieldPropsorInjectedFieldProps, but unfortunately we can't import them, as they aren't exported by the library.This PR exports them, so they can be used.