Fix logout button appears in two different menus #6230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Apr 30, 2021
| @@ -89,12 +80,9 @@ const Menu: FC<MenuProps> = props => { | |||
| leftIcon={ | |||
| resource.icon ? <resource.icon /> : <DefaultIcon /> | |||
| } | |||
| onClick={onMenuClick} | |||
There was a problem hiding this comment.
I refactored the <MenuItemLink> to let it pull the props it needs (rather than expecting them to be pushed by the <Sidebar>).
This greatly simplifies the creation of custom menus.
WiXSL
reviewed
Apr 30, 2021
|
Wait, since #5575 it's the menu's responsibility to reduce width when the sidebar is closed. I'm not sure why, but if it's the case this should be documented. |
|
OK, it's both the Sidebar AND the Menu's responsibility to reduce width, in order to support one use case: using a react-admin oss So this PR is ready. |
fzaninotto
force-pushed
the
simplify-menu-customization
branch
from
086b23f
to
baa545a
Compare
fzaninotto
force-pushed
the
simplify-menu-customization
branch
from
baa545a
to
d4256a5
Compare
djhi
requested changes
May 6, 2021
| @@ -89,12 +80,9 @@ const Menu: FC<MenuProps> = props => { | |||
| leftIcon={ | |||
| resource.icon ? <resource.icon /> : <DefaultIcon /> | |||
| } | |||
| onClick={onMenuClick} | |||
djhi
approved these changes
May 7, 2021
takayukioda
added a commit
to takayukioda/react-admin
that referenced
this pull request
Mar 23, 2022
`sidebarIsOpen` in _MenuItemLink_ component and `onMenuClick` in _Menu_ component has been deprecated in marmelab#6230 and their no longer needed to create custom menu components. Also there were some unused import statements, so I've clean them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6228