Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors and warnings in tests #6299

Merged
merged 1 commit into from
May 31, 2021
Merged

Fix errors and warnings in tests #6299

merged 1 commit into from
May 31, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented May 23, 2021

No description provided.

@WiXSL WiXSL changed the title Fix errors in tests Fix errors and warnings in tests May 24, 2021
@WiXSL
Copy link
Contributor Author

WiXSL commented May 30, 2021

Is this ok to be merged?

djhi
djhi approved these changes May 31, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fzaninotto fzaninotto merged commit 6610f8d into marmelab:master May 31, 2021
@fzaninotto
Copy link
Member

Thanks, too!

@fzaninotto fzaninotto added this to the 3.15.3 milestone May 31, 2021
@WiXSL WiXSL deleted the fix-remove-errors-tests branch May 31, 2021 12:15
@fzaninotto fzaninotto modified the milestones: 3.15.3, 3.16.0 May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WiXSL @fzaninotto @djhi