Fix notify function when no type is passed #6768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd had added that exact change in #6760, but reverted for some reason, It seems ok. |
djhi
requested changes
Nov 15, 2021
Comment on lines
55
to
59
| } else if (type) { | ||
| const { type: messageType, ...options } = type; | ||
| dispatch(showNotification(message, messageType, options)); | ||
| } else { | ||
| dispatch(showNotification(message)); |
There was a problem hiding this comment.
Thanks!
Suggested change
| } else if (type) { | |
| const { type: messageType, ...options } = type; | |
| dispatch(showNotification(message, messageType, options)); | |
| } else { | |
| dispatch(showNotification(message)); | |
| } else { | |
| const { type: messageType, ...options } = type || {}; | |
| dispatch(showNotification(message, messageType, options)); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6713 was fixing this problem but #6760 makes it happen again
Close #6767