Sanitize emptyText, enableGetChoices @ SAI #7015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't replicate the problem of DOM warnings. Can you please point to a CodeSandbox replicating the issue? |
|
Sure! Here's a fork that shows the issue using a new "Subtitle" input with a ReferenceArrayInput and SelectArrayInput. https://codesandbox.io/s/damp-river-jqr32?file=/src/posts/PostCreate.tsx |
WiXSL
approved these changes
Jan 17, 2022
|
Looks ok! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a SelectArrayInput as a child of a ReferenceArrayInput, DOM errors will be thrown for the props "emptyText" and "enableGetChoices". This commit sanitizes those props before they are passed to the FormControl component, which triggers the DOM error.