Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix <SaveButton formId> prop should be called <SaveButton form> #7658

Merged
merged 1 commit into from
May 9, 2022
Merged

[Doc] Fix <SaveButton formId> prop should be called <SaveButton form> #7658

merged 1 commit into from
May 9, 2022

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented May 7, 2022

Per MDN documentation https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-form

Buttons placed outside a form should accept form as the attribute instead of formId to associate with a form

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! 🙂
I agree this is a little bit better, even though none of the examples provided in the doc seem to actually work out of the box (because <Create> only accepts one child) 🙁
But we can already merge this change 🙂

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 4.0.4 milestone May 9, 2022
@djhi djhi merged commit 0d6081f into marmelab:master May 9, 2022
@fzaninotto fzaninotto changed the title [Doc] Update <SaveButton/> prop in <Form/> example [Doc] Fix <SaveButton formId> prop should be called <SaveButton form> May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants