Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add JsonSchemaForm doc #8056

Merged
merged 2 commits into from
Aug 9, 2022
Merged

[Doc] Add JsonSchemaForm doc #8056

merged 2 commits into from
Aug 9, 2022

Conversation

thibault-barrat
Copy link
Contributor

image

@thibault-barrat thibault-barrat added the RFR Ready For Review label Aug 9, 2022
@antoinefricker antoinefricker added this to the 4.2.7 milestone Aug 9, 2022
slax57
slax57 reviewed Aug 9, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be nice to include a screenshot of the UI produced by the provided example? (which we could also include in the EE doc btw)

slax57
slax57 approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

@slax57 slax57 requested a review from fzaninotto August 9, 2022 15:34
@fzaninotto fzaninotto merged commit ddbab79 into master Aug 9, 2022
@fzaninotto fzaninotto deleted the doc-json-schema-form branch August 9, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinefricker antoinefricker antoinefricker approved these changes

@slax57 slax57 slax57 approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@thibault-barrat @fzaninotto @slax57 @antoinefricker