-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SimpleFormIterator UI #8124
Conversation
The rationale for separating the remove button from the others in the first place was that it's destructive. Maybe we should keep that. Let me think again about the best compromise. Back to WIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice so far!! 😍
48f171e
to
93acc07
Compare
The different colors still make it clear enough, imho |
Woow this is great! |
OK, I've made up my mind, this is back to RFR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the ArrayInput
stories, specially Nested Inline
, the inputs look to dense.
And the separation line between items gets too close to the inputs
Co-authored-by: Aníbal Svarcas <WiXSL@users.noreply.github.com>
This story shows the "densest" density we can get. I still think it's not dense enough ;) You can see the default density in the As for the separator line, I'm not 100% satisfied with the result either, but the alternatives I tested were worse. |
fullWidth
prop to push actions to the row endinline
layout in the documentationBefore
After
The docs introduce this component with a nicer screenshot: