Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <SelectInput emptyValue> accepts null value #8235

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Fix <SelectInput emptyValue> accepts null value #8235

merged 2 commits into from
Oct 5, 2022

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Oct 5, 2022 •
edited
Loading

  • Document that null isn't a possible value for emptyValue
  • Throw an error if a developer tries to use it.

Refs #8060

@fzaninotto fzaninotto added the RFR Ready For Review label Oct 5, 2022
@fzaninotto fzaninotto mentioned this pull request Oct 5, 2022
Closed
@fzaninotto fzaninotto added WIP Work In Progress and removed RFR Ready For Review labels Oct 5, 2022
@fzaninotto fzaninotto changed the title [Doc] Fix <SelectInput emptyValue> doc for null values Fix <SelectInput emptyValue> accepts null value Oct 5, 2022
@fzaninotto fzaninotto merged commit 43054e1 into master Oct 5, 2022
@fzaninotto fzaninotto deleted the emptyvalue-doc branch October 5, 2022 11:52
@fzaninotto fzaninotto added this to the 4.4.1 milestone Oct 5, 2022
@fzaninotto fzaninotto added RFR Ready For Review and removed WIP Work In Progress labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiXSL WiXSL WiXSL approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @WiXSL