Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <AutocompleteInput validate={required()}> displays empty choice #8296

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Fix <AutocompleteInput validate={required()}> displays empty choice #8296

merged 3 commits into from
Oct 25, 2022

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Oct 24, 2022

AutocompleteInput should not display the empty choice when validate={required()}

@slax57 slax57 added the RFR Ready For Review label Oct 24, 2022
WiXSL
WiXSL suggested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@WiXSL WiXSL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useInput hook receives isRequiredOverride and resolves which isRequired is going to use and returns it in isRequired.
So I think this can be changed to simply isRequired={isRequired}

react-admin/packages/ra-ui-materialui/src/input/AutocompleteInput.tsx

Line 541 in 6a298cb

isRequired={

@fzaninotto fzaninotto merged commit 4bde333 into master Oct 25, 2022
@fzaninotto fzaninotto deleted the autocomplete-isrequired branch October 25, 2022 09:54
@fzaninotto fzaninotto added this to the 4.5.0 milestone Oct 25, 2022
@fzaninotto fzaninotto changed the title Fix AutocompleteInput displays empty choice when validate={required()} Fix <AutocompleteInput validate={required()}> displays empty choice Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiXSL WiXSL WiXSL requested changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@slax57 @fzaninotto @WiXSL