fix: warn when choices prop is undefined #8309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Oct 26, 2022
| @@ -161,6 +162,16 @@ export const SelectInput = (props: SelectInputProps) => { | |||
| source: sourceProp, | |||
| }); | |||
|
|
|||
| warning( | |||
| source === undefined, | |||
There was a problem hiding this comment.
This is wrong, as choices will always be undefined here
There was a problem hiding this comment.
Both source and allChoices variables are set by useChoicesContext just above this line. allChoices is set asynchrounously (return value of useList hook) so there we have to check for isLoading !== true before we throw. However, the source variable is set synchronously either by prop or from ChoicesContext and should be defined here.
| @@ -161,6 +162,16 @@ export const SelectInput = (props: SelectInputProps) => { | |||
| source: sourceProp, | |||
| }); | |||
|
|
|||
| warning( | |||
There was a problem hiding this comment.
The component should throw if it cannot render, not warn
There was a problem hiding this comment.
Agree, I'll change this also for the components from where I found this snippet.
fzaninotto
approved these changes
Oct 27, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8308