Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Count and ReferenceManyCount should allow to override the default sort #8732

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Mar 15, 2023

Fixes #8731

@slax57
Copy link
Contributor Author

slax57 commented Mar 15, 2023

In the end, I'm not so sure about setting the sort prop to null, because dataProvider implementations might contain code expecting non-null sort props, like:

const { field, order } = params.sort;

I think it's safer to keep the default value, and simply add the ability for the developers to override it.

Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
@djhi djhi added this to the 4.8.4 milestone Mar 16, 2023
@djhi djhi merged commit 6e65832 into master Mar 16, 2023
@djhi djhi deleted the fix-ReferenceManyCount-sort branch March 16, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceManyCount doe snot support sortBy and sortByOrder properties
2 participants