Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useInput callbacks are mutable #8824

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Fix useInput callbacks are mutable #8824

merged 1 commit into from
Apr 13, 2023

Conversation

fzaninotto
Copy link
Member

Supersedes #8780

@fzaninotto fzaninotto added the RFR Ready For Review label Apr 11, 2023
djhi
djhi reviewed Apr 11, 2023
View reviewed changes
packages/ra-core/src/form/useInput.ts
: event[0]?.target?.value ?? event[0]) as any;
controllerField.onChange(parse ? parse(eventOrValue) : eventOrValue);
});

const field = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we memo this ? Or even the end result of the function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't received any bug/performance report regarding this

@djhi djhi added this to the 4.9.3 milestone Apr 13, 2023
@djhi djhi merged commit 6c947c6 into master Apr 13, 2023
@djhi djhi deleted the fix-useinput-memoization branch April 13, 2023 08:41
@djhi djhi added the fix label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fzaninotto @djhi @slax57