Fix custom input's onChange handlers should have access to updated context value #8910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
approved these changes
May 15, 2023
|
@djhi May I let you check this comment and then merge if you approve this PR? 🙂 |
|
Sorry, the branch was deleted when I closed the merge master to next PR. Thanks for reporting! |
djhi
approved these changes
Jul 3, 2023
|
@slax57, I believe this wasn't included in the latest milestone and mentioned in the latest ChangeLog. |
|
Right, thanks for the heads-up @WiXSL 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating a project from ra-v3 to ra-v4 where the value of change inputs is taken from the Form state within the onChange / onBlur event handler (instead of its
e.target.valueargument), and it doesn't have the updated value.I found out that :
In react-admin v3 inputs run custom event handlers after react-final-form ones.
In react-admin v4 inputs run custom event handlers before react-hook-form ones.
So, changing this order of execution to match ra-v3 allows
useFormContext().getValues()to have the latest value inside the custom event handlers.Supersedes #8903