Expose setNotifications callback in NotificationContext to allow for a custom notifications center
#8914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. As it is a new faeture, can you please target the |
|
Your PR embarks commits that already belong to another branch... You probably messed up your rebase. |
|
Yeah I realized, I have now fixed my rebase. |
fzaninotto
approved these changes
May 16, 2023
slax57
approved these changes
May 23, 2023
|
Thanks! |
slax57
changed the title
setNotifications callback in NotificationContext to allow for a custom notifications center
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use case, we have a customized notification center.
We would like to let users acknowledge some of the notifications, so that would require us to expose the setNotifications method in order to rewrite some of the values stored in the notification context