-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Update Storybook to v7 & Cypress to use Vite #8936
Conversation
It seems the new storybook code panel rewrites the code and doesn't allow to see the surrounding code. For many of our stories, it means the code isn't explicit... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When launching the storybook, the terminal is filled with logs saying:
Can we avoid that? |
It only does that the first time right? If you start it again, it shouldn't display them |
That's right. But still, can we avoid it? |
As you probably noticed, the message includes a recommanded fix that is already applied in https://github.com/marmelab/react-admin/pull/8936/files#diff-cafe2123a72c4ce3a9f7e9ee4b0e188256eb02d7ec1e54fa2cadfac99b22f92bR38 Not sure what else I can do |
You've added @babel/plugin-proposal-private-property-in-object vs @babel/plugin-proposal-class-properties |
Good catch, there are actually three rules to add. It's done |
No description provided.