[Doc] Add Next.js app router install instructions #8965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Jun 1, 2023
| @@ -100,8 +102,3 @@ React-admin requires a valid dataProvider function to work.`); | |||
| </AuthContext.Provider> | |||
| ); | |||
| }; | |||
|
|
|||
| CoreAdminContext.defaultProps = { | |||
There was a problem hiding this comment.
Next.js 13 comes with React 18, which logs a warning for defaultProps in development. I fixed a few of these warnings, but we should definitely do the rest in another PR.
fzaninotto
commented
Jun 1, 2023
| @@ -119,10 +119,6 @@ export const CoreAdminRoutes = (props: CoreAdminRoutesProps) => { | |||
| ); | |||
| }; | |||
|
|
|||
| CoreAdminRoutes.defaultProps = { | |||
There was a problem hiding this comment.
This one was logging a warning AND was unused
slax57
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Next.js tutorial only cover the Pages router. Next.js is putting the App router front and foremost.
Solution
Document the App router integration, too.