Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demos don't allow to visualize source maps #9047

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jun 26, 2023

Problem

The yarn analyze command fails on the CRM and ecommerce demos, as some source maps can't be interpreted since the upgrade to Vite

Solution

Use the rollup plugin for source map visualization, and open the dataviz on build.

image

@djhi djhi merged commit 23ecac7 into master Jun 26, 2023
@djhi djhi deleted the demo-source-map branch June 26, 2023 12:16
@djhi djhi added this to the 4.11.5 milestone Jun 26, 2023
@slax57 slax57 modified the milestones: 4.11.5, 4.12.0 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants