Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update Tutorial to use TypeScript by default #9074

Merged
merged 5 commits into from
Jul 5, 2023

Conversation

adguernier
Copy link
Contributor

@adguernier adguernier commented Jul 4, 2023

Update js and jsx snippets to ts and tsx in Getting Started / Tutorial

@adguernier adguernier added the RFR Ready For Review label Jul 4, 2023
@fzaninotto fzaninotto changed the title [Doc] update some js and jsx snippet to ts and tsx [Doc] Update Tutorial to use TypeScript by default Jul 4, 2023
@fzaninotto
Copy link
Member

I think you should change the code type to typescript in all snippets, even if you don't add annotations. Otherwise, users will wonder why some snippets have a JS/TS switcher and some don't.

docs/Tutorial.md Outdated Show resolved Hide resolved
docs/Tutorial.md Show resolved Hide resolved
docs/Tutorial.md Show resolved Hide resolved
docs/Tutorial.md Show resolved Hide resolved
@djhi djhi merged commit 47e2dbd into master Jul 5, 2023
@djhi djhi deleted the doc-turn-jsx-snippets-in-tsx branch July 5, 2023 14:52
@fzaninotto fzaninotto added this to the 4.12.1 milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants