-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Update Tutorial to use TypeScript by default #9074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
changed the title
[Doc] update some js and jsx snippet to ts and tsx
[Doc] Update Tutorial to use TypeScript by default
Jul 4, 2023
I think you should change the code type to typescript in all snippets, even if you don't add annotations. Otherwise, users will wonder why some snippets have a JS/TS switcher and some don't. |
djhi
requested changes
Jul 4, 2023
fzaninotto
requested changes
Jul 5, 2023
slax57
reviewed
Jul 5, 2023
fzaninotto
approved these changes
Jul 5, 2023
slax57
approved these changes
Jul 5, 2023
djhi
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
js
andjsx
snippets tots
andtsx
in Getting Started / Tutorial