Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Guessers should not log in CI by default #9218

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Fix Guessers should not log in CI by default #9218

merged 1 commit into from
Aug 25, 2023

Conversation

fzaninotto
Copy link
Member

Problem

Guessers are convenient for tests... except they log their output to the console

Solution

  • Disable guessers log outside development by default
  • expose a prop to set the logging behavior

@fzaninotto fzaninotto added the RFR Ready For Review label Aug 25, 2023
djhi
djhi approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@djhi djhi added this to the 4.13.2 milestone Aug 25, 2023
@djhi djhi merged commit dac2c6d into master Aug 25, 2023
8 checks passed
@djhi djhi deleted the guesser-log-developoment branch August 25, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.13.2
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @djhi