[Doc] Explain how <PasswordInput> can be used to update a password
#9354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Oct 12, 2023
| @@ -47,3 +57,22 @@ Set the [`autocomplete` attribute](https://developer.mozilla.org/en-US/docs/Web/ | |||
| <PasswordInput source="password" inputProps={{ autocomplete: 'current-password' }} /> | |||
| ``` | |||
| {% endraw %} | |||
|
|
|||
There was a problem hiding this comment.
We probably need to explain how to have 2 password inputs, and how to validate that they are equal.
djhi
requested changes
Oct 13, 2023
docs/PasswordInput.md
Outdated
|
|
||
| ## Validating Identical Passwords | ||
|
|
||
| If you want to validate that the user has entered the same password in two different password inputs, you must use [global validation](./Validation.md#global-validation) at the form level: |
There was a problem hiding this comment.
Not really, validators have access to the other form values, so you could write an equalToFieldValidator:
const equalToFieldValidator = (source: string) => (value: any, allValues: FormValues) => ...
adguernier
reviewed
Oct 13, 2023
adguernier
reviewed
Oct 13, 2023
Co-authored-by: adrien guernier <adrien@marmelab.com>
adguernier
approved these changes
Oct 13, 2023
djhi
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The doc doesn't explain how to use
<PasswordInput>in Edit view. This may lead developers to expose passwords in clear.Solution
Be very clear about never exposing password, even in the Edition view.