Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Improve <StackedFilters> documentation #9364

Merged
merged 2 commits into from
Oct 17, 2023
Merged

[Doc] Improve <StackedFilters> documentation #9364

merged 2 commits into from
Oct 17, 2023

Conversation

mchaffotte
Copy link
Contributor

Improve StackedFilters documentation

@mchaffotte mchaffotte added the RFR Ready For Review label Oct 16, 2023
slax57
slax57 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some {% raw %} / {% endraw %} missing (jekyll requires to add them around code snippets that includes {{ ... }} otherwise it thinks this is a template variable to replace), so I added them.
Otherwise it's good for me, thanks!

@slax57 slax57 added this to the 4.15.1 milestone Oct 17, 2023
@slax57 slax57 merged commit 7ef30d7 into master Oct 17, 2023
1 of 2 checks passed
@slax57 slax57 deleted the doc-stackedfilters branch October 17, 2023 16:11
@slax57 slax57 changed the title doc: improve StackedFilters documentation [Doc] Improve <StackedFilters> documentation Oct 17, 2023
fzaninotto added a commit that referenced this pull request Oct 17, 2023
@fzaninotto
[no ci] review
6d74a63 
I pushed my edits to #9364 too late, so pushing them to master instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mchaffotte @slax57