Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix list filter snippets should use <SearchInput> instead of <TextInput> #9376

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

erwanMarmelab
Copy link
Contributor

Problem

On the documentation, videos, pictures and gifs are showing <SearchInput /> element, but in the code it's writed <TextInput label="Search" /> as this:

image

Solution

Match code and illustrations by apllying <SearchInput /> everywhere.

@erwanMarmelab erwanMarmelab added the RFR Ready For Review label Oct 20, 2023
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this seems good, thanks!

docs/Features.md Outdated Show resolved Hide resolved
docs/FilteringTutorial.md Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit aad0119 into master Oct 24, 2023
5 checks passed
@fzaninotto fzaninotto deleted the match-code-and-illustrations-for-SearchInput branch October 24, 2023 05:27
@fzaninotto fzaninotto added this to the 4.15.2 milestone Oct 24, 2023
@fzaninotto fzaninotto changed the title match code and illustrations for SearchInput [Doc] Fix list filter snippets should use <SearchInput> instead of <TextInput> Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants