Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add illustration for <SelectField> #9381

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

erwanMarmelab
Copy link
Contributor

@erwanMarmelab erwanMarmelab commented Oct 23, 2023

Problem

We actually don't show any illustration for the <SelectField /> component and we don't have stories on it.

Solution

Add an illustrations and stories for this component.

Doc before

image

Doc after

image

@erwanMarmelab erwanMarmelab added the RFR Ready For Review label Oct 23, 2023
Co-authored-by: adrien guernier <adrien@marmelab.com>
@fzaninotto fzaninotto merged commit dd38211 into master Oct 25, 2023
11 checks passed
@fzaninotto fzaninotto deleted the add-illustration-and-stories-for-SelectField branch October 25, 2023 14:05
@fzaninotto fzaninotto added this to the 4.15.2 milestone Oct 25, 2023
@fzaninotto fzaninotto changed the title [Doc] add illustration and stories for SelectField [Doc] Add illustration for <SelectField> Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants