Use resource definition to set default <Datagrid rowClick> value
#9466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
reviewed
Nov 22, 2023
| @@ -604,7 +592,7 @@ But now that the `users` resource has a `show` view, you can also link to it fro | |||
| // in src/posts.tsx | |||
| export const PostList = () => ( | |||
| <List> | |||
| <Datagrid rowClick="edit"> | |||
| <Datagrid> | |||
| - <ReferenceField source="userId" reference="users" /> | |||
| + <ReferenceField source="userId" reference="users" link="show" /> | |||
There was a problem hiding this comment.
Not for this PR but this should probably be automatic as well (detection of the available views with the same priorities)
| @@ -93,7 +91,7 @@ const ListViewGuesser = ( | |||
| ); | |||
| const inferredChild = new InferredElement( | |||
| listFieldTypes.table, | |||
| { hasEdit, hasShow }, | |||
There was a problem hiding this comment.
because it's no longer necessary 🤷
(ListGuesser used these props to calculate the rowClick prop, which we no longer needed, so might as well cleanup the props we send to InferredElement... Using null is something I saw in other components (EditGuesser if my recollection is correct) so I did the same thing)
djhi
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Datagrid>should be smarter than havingrowClickdefault tofalse.It can use the resource definition to look for an existing Show or Edit view, and default to those instead.
This PR changes the default value to be a bit smarter.
Minor Breaking Change
<Datagrid>will now make the rows clickable as soon as a Show or Edit view is declared on the resource.If you previously relied on the fact that the rows were not clickable by default, you now need to explicitly disable the
rowClickfeature: