Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <AutocompleteInput TextFieldProps> are not applied #9527

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix <AutocompleteInput TextFieldProps> are not applied #9527

merged 2 commits into from
Dec 15, 2023

Conversation

adguernier
Copy link
Contributor

@adguernier adguernier commented Dec 14, 2023 •
edited
Loading

Problem

Some props such as startAdornment, disabled etc are not applied to the renderer input of the <AutocompleInput> component, because TextFieldProps are not applied.

Solution

Re-order props to avoid TextFieldProps to be overloaded

adguernier
adguernier commented Dec 14, 2023
View reviewed changes
packages/ra-ui-materialui/src/input/AutocompleteInput.tsx
{...params}
{...TextFieldProps}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix

@adguernier adguernier added the RFR Ready For Review label Dec 14, 2023
@slax57 slax57 mentioned this pull request Dec 14, 2023
Closed
@slax57 slax57 added this to the 4.16.3 milestone Dec 15, 2023
@slax57 slax57 merged commit e3af328 into master Dec 15, 2023
11 checks passed
@slax57 slax57 deleted the fix-autocomplete-input-props-are-overrided branch December 15, 2023 08:54
@slax57 slax57 changed the title fix: AutocompleteInput TextFieldProps are not applied Fix <AutocompleteInput TextFieldProps> are not applied Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.16.3
Development

Successfully merging this pull request may close these issues.
2 participants
@adguernier @slax57