Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SelectArrayInput does not use recordRepresentation #9532

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: SelectArrayInput does not use recordRepresentation #9532

merged 1 commit into from
Dec 19, 2023

Conversation

adguernier
Copy link
Contributor

Problem

All react-admin choices inputs use the recordRepresentation defined on the <Resource> as the default optionText. Except the <SelectArrayInput> component. This forces users to define the optionText everytime they use it.

Solution

Use the recordRepresentation as every other inputs.

TODO

  • implement recordRepresentation in <SelectArrayInput>
  • write stories
  • write tests

@adguernier adguernier added the RFR Ready For Review label Dec 18, 2023
@djhi djhi added this to the 4.16.4 milestone Dec 19, 2023
@djhi djhi merged commit f913c20 into master Dec 19, 2023
11 checks passed
@djhi djhi deleted the fix-select-array-input-does-not-use-record-representation branch December 19, 2023 07:20
@slax57 slax57 mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.16.4
Development

Successfully merging this pull request may close these issues.
2 participants
@adguernier @djhi