Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useInfiniteGetList to skip getOne cache population for large responses #9536

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Dec 20, 2023

Just like useGetList, useInfiniteGetList shouldn’t prepopulate the getOne cache when dealing with large responses, for performance reasons.

Solution

  • Only populate the getOne cache for the results of the current page (not for all pages) (was already done, actually)
  • add a limit to skip getOne cache population for large responses

@djhi djhi merged commit 3dce829 into next Dec 22, 2023
11 checks passed
@djhi djhi deleted the useInfiniteGetList-max-data-length-to-cache branch December 22, 2023 10:44
@djhi djhi added this to the 5.0.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants