Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ResettableTextField size prop can't be overridden #9553

Closed
wants to merge 3 commits into from

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Jan 3, 2024

Fixes #9546

@PedroPerpetua
Copy link
Contributor

This doesn't fix #9546 - the Textfield size should be moved to the themeing, not props; in fact, you can already override it with props - this PR effectively does nothing.

@fzaninotto
Copy link
Member

@WiXSL The author of the issue has also opened a PR to fix it (see #9546). Both your PRs are identical, so it's hard to choose the keeper. For this time, we'll keep the other one and close yours, but it's nothing personal, we still love your contributions!

@fzaninotto fzaninotto closed this Jan 4, 2024
@WiXSL WiXSL deleted the fix-textfield-size branch January 4, 2024 13:22
@WiXSL
Copy link
Contributor Author

WiXSL commented Jan 4, 2024

That's great!
The important thing is to maintain the project stable for everyone, I don't mind If are PR's made by me or not, haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants