Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Fix new deal does not appear in the correct order in CRM #9582

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

adguernier
Copy link
Contributor

@adguernier adguernier commented Jan 12, 2024

Follows #9581

examples/crm/src/deals/DealCreate.tsx Outdated Show resolved Hide resolved
@fzaninotto fzaninotto added RFR Ready For Review and removed WIP Work In Progress labels Jan 15, 2024
@fzaninotto fzaninotto changed the title Fix new deal does not appear in the correct order in CRM demo [Demo] Fix new deal does not appear in the correct order in CRM Jan 15, 2024
@@ -35,8 +35,8 @@ const DealList = () => {
component="div"
>
<DealListContent />
<DealCreate open={!!matchCreate} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this way, DealCreate can grab the list of deals from the ListContext - this saves one query and makes the post save process faster.

@djhi djhi merged commit b619443 into master Jan 16, 2024
11 checks passed
@djhi djhi deleted the fix-new-deal-does-not-appear-in-the-correct-order branch January 16, 2024 12:23
@djhi djhi added this to the 4.16.7 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants