Introduce ReferenceFieldBase #9698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanMarmelab
approved these changes
Mar 6, 2024
fzaninotto
requested changes
Apr 5, 2024
Comment on lines
72
to
77
| return id == null ? ( | ||
| emptyText ? ( | ||
| <Typography component="span" variant="body2"> | ||
| {emptyText && translate(emptyText, { _: emptyText })} | ||
| </Typography> | ||
| ) : null |
There was a problem hiding this comment.
it seems to me that this case is no longer handled
There was a problem hiding this comment.
Storybook disagrees with you. Having no id will disable the query in useReferenceFieldController so no referenceRecord will be available at L146 in this file thus showing the empty message
There was a problem hiding this comment.
There was an error in the useReferenceFieldController though. Both the tests and the storybook show that all empty cases are handled
There was a problem hiding this comment.
Except in the previous code, the empty text was displayed in a Typography. That's no longer the case.
| options: UseReferenceFieldControllerOptions<ReferenceRecordType> | ||
| ): UseReferenceFieldControllerResult<ReferenceRecordType> => { | ||
| const { source, link = 'edit', reference, queryOptions } = options; | ||
| const record = useRecordContext<RecordType>(options); |
fzaninotto
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While working on the alternative UI libraries demos, we had to re-implement all the reference fields and inputs logic.
Solution
Add core headless versions for these components
This PR introduces only the
ReferenceFieldBase.Tasks