Fix flaky tests #9952
Merged
Fix flaky tests #9952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
djhi
commented
Jun 25, 2024
•
djhi
commented
- Fix useDelete tests
- Fix create-react-admin tests
slax57
requested changes
Jun 25, 2024
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
fzaninotto
reviewed
Jun 26, 2024
| expect(screen.queryByText('mutating')).not.toBeNull(); | ||
| }); | ||
| expect(screen.queryByText('Hello')).not.toBeNull(); | ||
| expect(screen.queryByText('World')).not.toBeNull(); | ||
| await waitFor(() => { |
There was a problem hiding this comment.
the default timeout for waitFor is 1000ms. The tested story adds a delay of 1000ms to the delete. It's logical that this may fail from time to time.
I advise to reduce the delay to 500 in the story to make it more robust
fzaninotto
reviewed
Jun 26, 2024
| @@ -20,6 +20,9 @@ test("should pass", async () => { | |||
| ? ` | |||
|
|
|||
| // Sign in | |||
| // Ensure the form is fully loaded before interacting with it | |||
| await new Promise((resolve) => setTimeout(resolve, 1000)); | |||
There was a problem hiding this comment.
You should use an assertion in a waitfor instead of a timeout. Same for the other 2 instances
There was a problem hiding this comment.
We already do. I still had to add this
There was a problem hiding this comment.
Instead, add a timeout option to the initial findByLabelText, as it proxies its options to waitFor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.