Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <SimpleShowLayout> uses a wrong translation key for field labels #9966

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jun 28, 2024

The default SourceContext introduced by 4d9820d breaks default field labels.

Closes #9965

@fzaninotto fzaninotto added the RFR Ready For Review label Jun 28, 2024
@fzaninotto fzaninotto changed the title Fix-default-translation-key Fix SimpleShowLayout uses a wrong translation ket for field labels Jun 28, 2024
@fzaninotto fzaninotto changed the title Fix SimpleShowLayout uses a wrong translation ket for field labels Fix <SimpleShowLayout> uses a wrong translation ket for field labels Jun 28, 2024

describe('useTranslateLabel', () => {
const TranslateLabel = ({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The components to test have moved to the stories file

@slax57 slax57 changed the title Fix <SimpleShowLayout> uses a wrong translation ket for field labels Fix <SimpleShowLayout> uses a wrong translation key for field labels Jul 1, 2024
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@slax57 slax57 added this to the 5.0.3 milestone Jul 1, 2024
@slax57 slax57 merged commit 7a79484 into master Jul 1, 2024
14 checks passed
@slax57 slax57 deleted the fix-default-translation-key branch July 1, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleShowLayout does not pass resource to Labeled Component, translation fails
2 participants