[Doc] Fix Remix installation instructions #9982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adguernier
approved these changes
Jul 9, 2024
adguernier
reviewed
Jul 9, 2024
docs/Remix.md
Outdated
| tsconfigPaths(), | ||
| ], | ||
| + ssr: { | ||
| + noExternal: ['ra-data-json-server'] |
There was a problem hiding this comment.
Suggested change
| + noExternal: ['ra-data-json-server'] | |
| + noExternal: ['ra-data-json-server'] // the dataProvider you are using |
fzaninotto
requested changes
Jul 9, 2024
docs/Remix.md
Outdated
| **Tip**: If you're using yarn, Remix and react-admin both install `react-router`, and due to the way each library handles its dependencies, this results in duplicate packages. To avoid this, use [yarn resolutions](https://classic.yarnpkg.com/en/docs/selective-version-resolutions/) to force Remix to use the same version of `react-router` as react-admin. So add the following to the `package.json` file: | ||
|
|
||
|
|
||
| **Tip**: As Remix now use Vite for SSR too, you'll have to add the following to the `vite.config.ts` file: |
There was a problem hiding this comment.
you also need to remove the part starting L92 that talks about modifying the remix.conf.js
fzaninotto
approved these changes
Jul 10, 2024
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Remix install instructions don't work with the latest version of Remix, which now uses Vite.
Fix #9974