Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement a timer in the presenter view #430

Merged
merged 6 commits into from
Feb 23, 2022
Merged

implement a timer in the presenter view #430

merged 6 commits into from
Feb 23, 2022

Conversation

chrisns
Copy link
Contributor

@chrisns chrisns commented Feb 18, 2022

addresses #314

@yhatt yhatt self-requested a review February 19, 2022 05:16
@yhatt yhatt linked an issue Feb 19, 2022 that may be closed by this pull request
Timer in presenter view #314
Closed
@chrisns @yhatt
Update src/templates/bespoke/presenter/presenter-view.tsx
f370ead 
Co-authored-by: Yuki Hattori <yukihattori1116@gmail.com>
@chrisns
Copy link
Contributor Author

chrisns commented Feb 19, 2022

Hey @yhatt thanks for all the great feedback on my prs!

@chrisns
Copy link
Contributor Author

chrisns commented Feb 23, 2022

@yhatt this and the other two prs ok to merge and bump the version? (saves me doing ugly patching locally for my own needs)

@yhatt yhatt merged commit f2967c7 into marp-team:main Feb 23, 2022
@chrisns chrisns deleted the timer branch February 23, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhatt yhatt yhatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timer in presenter view
2 participants
@chrisns @yhatt