Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added CW1155 support #11

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Conversation

javiersuweijie
Copy link
Contributor

Added CW1155 support addressing #10

test result: ok. 32 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests cw-asset

running 30 tests

@larry0x
Copy link
Contributor

larry0x commented Jul 8, 2022

thanks @javiersuweijie, will review soon

@larry0x
Copy link
Contributor

larry0x commented Jul 10, 2022

@javiersuweijie i'm going to merge this PR now, and introduce a few changes in a separate PR.

two questions:

besides unit tests, have you tested this with an actual cw1155 contract in a testing environment, such as localterra?

do you want your name to be added to the authors list in Cargo.toml? if yes, do you wish to provide an email?

@larry0x larry0x merged commit d6697f1 into mars-protocol:main Jul 10, 2022
@larry0x larry0x mentioned this pull request Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants