[SC-423] Add upgradable oracle #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrutko
approved these changes
May 9, 2024
test/mocks/PriceSourceMock.sol
Outdated
| ) { | ||
| return (0, latestAnswer, 0, 0, 0); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
A new line could be added at the end since the file is edited
There was a problem hiding this comment.
done, added to the other file too
lucas-manuel
requested changes
May 15, 2024
| uint80 answeredInRound | ||
| ) { | ||
| return (0, latestAnswer, 0, 0, 0); |
There was a problem hiding this comment.
This should be returning all values from the tuple since they're all returned from the oracle, can add another setter setLatestRoundData to set these values within the mock.
There was a problem hiding this comment.
I've further restricted what gets returned and refactored the interface setup to not overload the price source one.
lucas-manuel
added
Status: Revisions Needed
and removed
Status: Ready for Review
labels
|
I refactored this a bit to make it more clear it's specific to Morpho Blue instead of a general upgradable oracle. |
|
Coverage after merging SC-423-upgradable-oracle into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
barrutko
approved these changes
May 16, 2024
lucas-manuel
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows swapping an oracle price feed for Morpho Blue. This will be used by Spark Gov to set the oracle for markets on Morpho Blue.