[SC-432] Add weETH oracle #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging SC-432-add-weeth-oracle into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucas-manuel
approved these changes
May 13, 2024
There was a problem hiding this comment.
The new file has zero coverage from some reason on foundry, but I added logs to all branches in functions and constructor to ensure that the paths were getting hit in the tests.
Also manually verified that the return price is correct against the latest block using the right values, comparing against coingecko ETH and WEETH price and etherscan rate.
barrutko
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding exchange rate oracle for weETH in anticipation of upcoming onboarding into SparkLend.
Code is almost identical to the Lido and Rocket Pool ones, so I would diff one of those to compare.
Note: coverage seems broken? There is almost certainly coverage on the lines mentioned. I don't know what's going on here. Lots of problems with coverage lately.