Add check in try-catch for zero length revert #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging audit-changes into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucas-manuel
approved these changes
Jun 12, 2024
barrutko
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback from the audit. Add check for zero length reverts in try catch for
CappedFallbackRateSource. Users can forcibly trigger this catch block of code by setting the gas limit to be out of gas inside the inner function. Likely this is not abusable in practise because the remainder of the call will be limited in gas remaining, but it's something to guard against out of an abundance of caution.Regular errors will still trigger this section appropriately and complete execution with the
defaultRate.Examples added in the tests.
Also, added new audit report.