[SC-406] Optional Max DSR #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-manuel
requested changes
Apr 23, 2024
lucas-manuel
added
Status: Revisions Needed
and removed
Status: Ready for Review
labels
barrutko
reviewed
Apr 23, 2024
barrutko
previously approved these changes
Apr 24, 2024
lucas-manuel
previously approved these changes
Apr 24, 2024
|
Coverage after merging SC-406-option-to-disable-max-dsr into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
barrutko
approved these changes
Apr 24, 2024
lucas-manuel
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On L2s it makes sense to completely trust the bridge and just burn admin access. As such we have been setting the max dsr to an arbitrarily high value (1000% / year). While this is fine in practise, it is an improvement to allow for the oracle to just disable this feature explicitly. This allows for longer durations for
rpowcomputation before it overflows. With 1000% APY you have an overflow if no update is performed within 20 years which again is fine in practise, but we can remove this limiter.