[SC-467] Update to latest xchain-helpers #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-manuel
requested changes
Jun 12, 2024
Comment on lines
+46
to
+48
| function relayMessagesAcrossBridge() internal override { | ||
| bridge.relayMessagesToDestination(true); | ||
| } |
There was a problem hiding this comment.
I think we can just replace this abstract function now no?
There was a problem hiding this comment.
We can't. I get that it looks like duplicate code, but it's a different using at the top so the function call is actually different and specific to the domain.
barrutko
previously approved these changes
Jun 26, 2024
|
Coverage after merging SC-467-update-to-latest-xchain-helpers into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucas-manuel
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to the refactored version of xchain-helpers with generic receivers. Also, some minor cleanup with naming, import ordering, etc.