Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit config #251

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

sirosen
Copy link
Collaborator

@sirosen sirosen commented Feb 6, 2023

  • update from gitlab mirror for flake8 to latest
  • pre-commit autoupdate & updadup
  • remove dependency on importlib-metadata from flake8 hook
  • apply changes from fixers (black modified whitespace)

After the above, flake8-bugbear was failing with B907. This is one of the opinionated warnings, and it's not fully accurate to the context of f-strings which are part of an external interface. As such, rather than make changes which could impact library consumers, suppress B907.

- update from gitlab mirror for flake8 to latest
- pre-commit autoupdate & updadup
- remove dependency on importlib-metadata from flake8 hook
- apply changes from fixers (black modified whitespace)

After the above, flake8-bugbear was failing with B907. This is one of
the opinionated warnings, and it's not fully accurate to the context
of f-strings which are part of an external interface. As such, rather
than make changes which could impact library consumers, suppress B907.
@sirosen sirosen merged commit 9abd4b3 into marshmallow-code:dev Feb 6, 2023
@sirosen sirosen deleted the update-precommit branch February 6, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant