Js/fix eslint #413
Merged
Js/fix eslint #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnuria
force-pushed
the
js/fix-eslint
branch
from
37e4797 to
f59ebb4
Compare
darnuria
commented
Nov 22, 2020
| @@ -639,24 +641,22 @@ function impressionTicket(data, response, unit = 'kg', tvaStuff = () => '', sumF | |||
| ${showPaiement(data.id_moyen)} | |||
| <p>Ticket client à conserver.</p> | |||
| <p>Date d'édition du ticket : ${moment().format('DD/MM/YYYY - HH:mm')}</p> | |||
| ${showTickets(data, unit)} | |||
There was a problem hiding this comment.
Was never read in showTickets
| const item = (data.hasOwnProperty('items') && data.items.length > 0 | ||
| ? `<p>Ventes</p>${dashBreak}${showTicket(data.items, window.OressourceEnv.types_dechet, unit)}` | ||
| ? `<p>Ventes</p>${dashBreak}${showTicket(data.items, window.OressourceEnv.types_dechet)}` |
There was a problem hiding this comment.
unit was passed around and in showTicketlink to fct it wasn't read at all.
| } | ||
| const showMoyen = (moyens, moyenId) => ( | ||
| moyens.find(({id}) => id === moyenId).nom || "moyen de paiement inconnu!" | ||
| ); |
There was a problem hiding this comment.
just little trick to remove {} and return since it's an expression.
| @@ -385,16 +387,16 @@ function login(onSuccess = undefined) { | |||
| const form = new FormData(document.getElementById('formLogin')); | |||
| const username = form.get('mail'); | |||
| const password = form.get('pass'); | |||
| const fetchPromise = fetch('../moteur/login_post.php', { | |||
There was a problem hiding this comment.
fetchPromise was never read.
| @@ -52,7 +45,7 @@ class NumPad { | |||
|
|
|||
| const div = document.createElement('div'); | |||
| div.setAttribute('class', 'panel panel-info'); | |||
| div.innerHTML = stripIndent` | |||
| div.innerHTML = ` | |||
There was a problem hiding this comment.
Didn't know why I found that cool back in 2015...
| // remove the shortest leading indentation from each line | ||
| const indent = Math.min(...html[0].match(/^[ \t]*(?=\S)/gm).map(el => el.length)); | ||
| return html[0].replace(new RegExp('^[ \\t]{' + indent + '}', 'gm'), ''); | ||
| } |
There was a problem hiding this comment.
Removed it ended up eating CPU in the wild.
La CI n'a jamais été mise en place mais on demandais a des VM de pop dans le cloud a chaque PR, allez stop le gachi en attendant d'avoir un vrai setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.