New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert logbook list to typescript, organise data and types better #42

Merged

martinbagshaw merged 1 commit into master from chore-convert-logbook-to-typescript

Oct 25, 2020

Owner

martinbagshaw commented Oct 24, 2020

Ticks off Convert Logbook view to TypeScript #36
Organise data composition better, remove unused things
Common types go in a common types file
Still to fix some TypeScript warning in <Logbook>. Props are not getting combined, or detected properly for <Search />

Links / my line of enquiry:


          convert logbook list to typescript, organise data and types better

6dd9fb8

martinbagshaw self-assigned this

martinbagshaw added the TODO label

martinbagshaw linked an issue

that may be closed by this pull request

Convert Logbook view to TypeScript #36

Closed

5 tasks

martinbagshaw marked this pull request as ready for review

October 25, 2020 08:16

Owner Author

martinbagshaw commented Oct 25, 2020

Work out and fix the warning in <Logbook /> at a later date.
everything else in this PR is fine.
https://github.com/martinbagshaw/ReactLogbook/pull/42/files#diff-37dbdc4c07f6fc903ff0a4d94e6a0e0c5c4da6dee17a8076b2573de8f0a2de51L58

martinbagshaw merged commit b04e466 into master

martinbagshaw deleted the chore-convert-logbook-to-typescript branch

October 25, 2020 08:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TODO