Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MSBuild for assembly attributes #754

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Use MSBuild for assembly attributes #754

merged 1 commit into from
Oct 25, 2023

Conversation

martincostello
Copy link
Owner

Remove CommonAssemblyInfo.cs and use MSBuild to set assembly attributes.

Remove `CommonAssemblyInfo.cs` and use MSBuild to set assembly attributes.
@martincostello martincostello added enhancement .NET Pull requests that update .net code labels Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d58c61f) 91.59% compared to head (0b8349c) 91.76%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   91.59%   91.76%   +0.16%     
==========================================
  Files          22       22              
  Lines        1214     1214              
  Branches      126      126              
==========================================
+ Hits         1112     1114       +2     
+ Misses         74       72       -2     
  Partials       28       28              
Flag Coverage Δ
linux 56.50% <ø> (+0.16%) ⬆️
macos 56.67% <ø> (+0.16%) ⬆️
windows 91.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit ba65a2f into main Oct 25, 2023
12 checks passed
@martincostello martincostello deleted the tidy-up branch October 25, 2023 18:27
@martincostello martincostello added this to the v3.3.0 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant